TSimpleGraph Issues (and wish list)

[Kambiz]

Vladimir, I checked the issue with the latest version of SG, all was fine.

[Vladimir]

I found the problem, was my fault, I've added a number of new shapes and properties to the component and also changed SGDemo for my task, for more convinient and fast work IMHO. Are you interested?

[taazz2]

A find in node would be most helpful!

you need to be more specific what exactly you want to search in a node, As it is you have multiple choices in searching in nodes including the foreach methods with a custom callback to do what ever you want to do.

[taazz2]

Hi,

two things

1) is the wish list published anywhere so any one who wants to can start implementing a specific feature?
2) can you sent me the grouping enhancements with a short descriptions on what it needs to be completed?

For my needs of groupings and layering I have implement a simple layering and I was thinking to create a Group Node which will contain the grouped nodes
act as proxy for the drawing and handle the keyboard and mouse events it self. Since I haven't code anything for grouping yet it would be better to work on your grouping code instead and add what ever needs to be added.

thank you

[hungary2006]

I must say this is a good and useful component, is there any hope on using it in Delphi XE2 and Win32 and Win64?

[taazz2]

XE2 Win32 wouldn't be too much trouble I think that just a update to the .inc file should be all that it takes for 64bit thought I was hopping to download the trial version and try to port it but the 15 days limit is to low for me and I don't think I can manage a port in that time.

[hungary2006]

I have send you an email.com

XE2 Win32 wouldn't be too much trouble I think that just a update to the .inc file should be all that it takes for 64bit thought I was hopping to download the trial version and try to port it but the 15 days limit is to low for me and I don't think I can manage a port in that time.

[taazz2]

I have send you an email.com

Email Received, thank you.

I'll see what I can do about it.

[hungary2006]

Alright, if you figure out please do not hesitate to show us how you do it.

[taazz2]

I had a quick look today and I managed to install it, compile the demo program, for 32 and 64bits with out a problem there are 3 thinks you need to be aware off

• search and replace PAnsiChar with PChar.
• TGraphLink.CreateTextRegion method has a line that reads < SetLength(TmpText, StrLen(PChar(TmpText))); > change it to <SetLength(TmpText, Length(TmpText)-4);>This might not be the proper way to solve this I haven't found out why those 2 setlength statements are needed in there yet I'm trying to understand. Perhaps Kambiz could help us with that.
• TSimpleGraph.WMPaint method. Rename the 2 variables Width, Height to W, H use the rename refactoring of Delphi Ctrl+Shift+E

So far everything seems to work as expected I can even open the existing samples with out a problem save them and then reopen them with a D2007 build Demo app no problems, I guess that the TReader, TWriter classes do a good job tagging, saving and loading the strings in either unicode or ansi format.

Although I have build a 64bit exe I do not have any 64bit OS installed to test it but I do not expect any problems.

I have attached an updated DELPHIAREA.INC file that understands Delphi XE2 but you dont need it as this inc file works in reverse order than the rest of the them eg it assumes always the latest compiler and undefines if older compiler is detected.

IF you havent grabbed it already go to http://forum.delphiarea.com/viewtopic.php?f=5&t=1949 and download my extensions to simplegraph for GDI+ and run the first search and replace on the UEvsSgCanvas.pas as well.

If you have any problems post a query here and I"ll try to help.

[Kambiz]

Thank you taazz2.

Code: Select all

SetLength(TmpText, StrLen(PChar(TmpText)))

TmpText is a buffer for the final string. Its length is larger than the actual string, because of that I used StrLen to find the actual data string using its null character terminator. I don't think this line should be identical for both 32 and 64 bit compilers.

[hungary2006]

Thanks and did you get rad running?

I had a quick look today and I managed to install it, compile the demo program, for 32 and 64bits with out a problem there are 3 thinks you need to be aware off

• search and replace PAnsiChar with PChar.
• TGraphLink.CreateTextRegion method has a line that reads < SetLength(TmpText, StrLen(PChar(TmpText))); > change it to <SetLength(TmpText, Length(TmpText)-4);>This might not be the proper way to solve this I haven't found out why those 2 setlength statements are needed in there yet I'm trying to understand. Perhaps Kambiz could help us with that.
• TSimpleGraph.WMPaint method. Rename the 2 variables Width, Height to W, H use the rename refactoring of Delphi Ctrl+Shift+E

So far everything seems to work as expected I can even open the existing samples with out a problem save them and then reopen them with a D2007 build Demo app no problems, I guess that the TReader, TWriter classes do a good job tagging, saving and loading the strings in either unicode or ansi format.

Although I have build a 64bit exe I do not have any 64bit OS installed to test it but I do not expect any problems.

I have attached an updated DELPHIAREA.INC file that understands Delphi XE2 but you dont need it as this inc file works in reverse order than the rest of the them eg it assumes always the latest compiler and undefines if older compiler is detected.

IF you havent grabbed it already go to http://forum.delphiarea.com/viewtopic.php?f=5&t=1949 and download my extensions to simplegraph for GDI+ and run the first search and replace on the UEvsSgCanvas.pas as well.

If you have any problems post a query here and I"ll try to help.

[taazz2]

Thank you taazz2.

Code: Select all

SetLength(TmpText, StrLen(PChar(TmpText)))

TmpText is a buffer for the final string. Its length is larger than the actual string, because of that I used StrLen to find the actual data string using its null character terminator.

Not in that method. You already have the correct size and string a few lines above and you do

Code: Select all

      TmpText := Trim(Text);
      SetLength(TmpText, Length(TmpText) + 4);
      ..
      ..
      SetLength(TmpText, StrLen(PChar(TmpText)));


I don't think this line should be identical for both 32 and 64 bit compilers.

Since this line does not depend in anything string specific its just an undo and it only uses a system function with well defined behavior I do expect it to work as it is on 64 bit compilers.

[taazz2]

Thanks and did you get rad running?

Yes, I"m a happy user thank you.

[hungary2006]

Following all your steps and I fire up Delphi XE2, and error TSimpleGraph occurred.

I had a quick look today and I managed to install it, compile the demo program, for 32 and 64bits with out a problem there are 3 thinks you need to be aware off

• search and replace PAnsiChar with PChar.
• TGraphLink.CreateTextRegion method has a line that reads < SetLength(TmpText, StrLen(PChar(TmpText))); > change it to <SetLength(TmpText, Length(TmpText)-4);>This might not be the proper way to solve this I haven't found out why those 2 setlength statements are needed in there yet I'm trying to understand. Perhaps Kambiz could help us with that.
• TSimpleGraph.WMPaint method. Rename the 2 variables Width, Height to W, H use the rename refactoring of Delphi Ctrl+Shift+E

So far everything seems to work as expected I can even open the existing samples with out a problem save them and then reopen them with a D2007 build Demo app no problems, I guess that the TReader, TWriter classes do a good job tagging, saving and loading the strings in either unicode or ansi format.

Although I have build a 64bit exe I do not have any 64bit OS installed to test it but I do not expect any problems.

I have attached an updated DELPHIAREA.INC file that understands Delphi XE2 but you dont need it as this inc file works in reverse order than the rest of the them eg it assumes always the latest compiler and undefines if older compiler is detected.

IF you havent grabbed it already go to http://forum.delphiarea.com/viewtopic.php?f=5&t=1949 and download my extensions to simplegraph for GDI+ and run the first search and replace on the UEvsSgCanvas.pas as well.

If you have any problems post a query here and I"ll try to help.